-
-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: print which tag is invalid #1375
base: master
Are you sure you want to change the base?
Conversation
and the regex used for validation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this would be a good addition, but without the regexps in the message as it will easily flood the output.
Note that #1297 should not have introduced any new raised exception, as it was already raised before and it was the reason I made #1297 initially, to provide a workaround to this exception. So I am also interested in finding why it wasn't raised before for you and now it is.
I have setup a minimal reproducer in https://github.com/carlossg/commitizen-test with my patch
I can remove the regex to be less verbose |
and the regex used for validation
Description
Starting in 4.4.0 due to #1297 when an invalid tag is present an exception is thrown. I would expect the tag is ignored.
This PR only improves the message, not the root cause
Before
After
Checklist
poetry all
locally to ensure this change passes linter check and testExpected behavior
Steps to Test This Pull Request
cz bump --dry-run
Additional context