fix(bump): manual version bump if prerelease offset is configured #1358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckagerer
force-pushed
the
fix/manual-version-with-prerelease-offset-in-config
branch
from
9377d32 to
89677ae
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1358 +/- ##
==========================================
+ Coverage 97.33% 97.55% +0.21%
==========================================
Files 42 55 +13
Lines 2104 2620 +516
==========================================
+ Hits 2048 2556 +508
- Misses 56 64 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
If you use the prerelase offset in the .cz.toml, as in the following example, no bump with a manual version number is possible. The error occurs when bumping with manual version number: cz bump 9.8.7 --prerelease-offset cannot be combined with MANUAL_VERSION ```toml [tool.commitizen] changelog_incremental = true tag_format = "v$version" update_changelog_on_bump = true version = "1.2.0b13" prerelease_offset = 1 ```
ckagerer
force-pushed
the
fix/manual-version-with-prerelease-offset-in-config
branch
from
89677ae to
dfd2fdf
Compare
Lee-W
approved these changes
Feb 18, 2025
There was a problem hiding this comment.
Thanks @ckagerer !
@woile @noirbizarre This PR looks good to me. I'm going to merge it this days if there's no objection
Lee-W
added
the
pr-status: ready-to-merge
|
LGTM
…On Tue, 18 Feb 2025, 07:53 Wei Lee, ***@***.***> wrote:
***@***.**** approved this pull request.
Thanks @ckagerer <https://github.com/ckagerer> !
@woile <https://github.com/woile> @noirbizarre
<https://github.com/noirbizarre> This PR looks good to me. I'm going to
merge it this days if there's no objection
—
Reply to this email directly, view it on GitHub
<#1358 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AATXJWGCZRL32V4GBW6HOAT2QMGLZAVCNFSM6AAAAABXJTTSUWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMMRTGE2TMNJYG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If a prerelease offset is configured (I introduced this about 2 years ago with PR #614), no bump is possible with the manual version.
To do this, the configuration must first be changed and then reset after the bump.
For this reason, it makes more sense to remove the check that prevents the manual bump.
Checklist
poetry alllocally to ensure this change passes linter check and testUpdate the documentation for the changesExpected behavior
Bumping a manual version works without changing the configuration file.
Steps to Test This Pull Request
cz bump 9.8.7Additional context