-
-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(config_files): add suport for "cz.toml" config file #1130
Conversation
Related to #1111 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1130 +/- ##
==========================================
+ Coverage 97.33% 97.54% +0.20%
==========================================
Files 42 55 +13
Lines 2104 2486 +382
==========================================
+ Hits 2048 2425 +377
- Misses 56 61 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Please add a test: You can do something similar to: Lines 217 to 224 in 796a160
|
@woile I added test to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Add support to configure commitizen through
cz.toml
file.Checklist
./scripts/format
and./scripts/test
locally to ensure this change passes linter check and testExpected behavior
Be able to initialize and configure commitizen through
cz.toml
Screenshots
Test the new config file
cz init
and you will see the new possible config fileSuccessfully created the
cz.toml
:About this feature be already covered by current tests
Since its just an new filename, not extension nor format, its already fully covered by tests.
tests/test_conf.py::TestReadCfg
already cover the tests on.toml
extension:And also pass all other tests:
Closes: #1111