Skip to content

fix(changelog): include latest change when dry run and incremental #1026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 14, 2024
Merged

fix(changelog): include latest change when dry run and incremental #1026

merged 1 commit into from
Mar 14, 2024

Conversation

woile
Copy link
Member

@woile woile commented Mar 14, 2024 •
edited
Loading

Closes #1024

Description

Checklist

  • Add test cases to all the changes you introduce
  • Run ./scripts/format and ./scripts/test locally to ensure this change passes linter check and test
  • Test the changes on the local machine manually
  • Update the documentation for the changes

Expected behavior

Steps to Test This Pull Request

Additional context

@woile woile requested review from Lee-W and noirbizarre as code owners March 14, 2024 10:11
@woile woile force-pushed the fix/1024-bump-changelog-incremental branch 2 times, most recently from 11747e2 to d5dd019 Compare March 14, 2024 10:26
@woile woile force-pushed the fix/1024-bump-changelog-incremental branch from d5dd019 to 47762b6 Compare March 14, 2024 11:02
@woile
Copy link
Member Author

woile commented Mar 14, 2024

@noirbizarre would this change be okay with you? One test for the hooks has changed a bit

noirbizarre
noirbizarre approved these changes Mar 14, 2024
View reviewed changes
Copy link
Member

@noirbizarre noirbizarre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go on, LGTM to fix the issue.

I'll propose a refactoring later to have something more robust to handle changelog in bump command

@woile woile mentioned this pull request Mar 14, 2024
Closed
@woile woile merged commit 3c9988a into master Mar 14, 2024
16 checks passed
@woile woile deleted the fix/1024-bump-changelog-incremental branch March 14, 2024 18:37
This was referenced Mar 14, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noirbizarre noirbizarre noirbizarre approved these changes

@Lee-W Lee-W Awaiting requested review from Lee-W Lee-W is a code owner

Assignees
No one assigned
Labels
pr-status: wait-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using --changelog regenerates the full changelog instead of just the current increment
2 participants
@woile @noirbizarre