Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused (hackage) tarball handling code for StackageSdistR #341

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

juhp
Copy link
Contributor

@juhp juhp commented Feb 2, 2025

I noticed this code seems unused since
http://hackage.fpcomplete.com/package/ seems 404

So afaict this can be removed safely. Does anyone see a problem?

@juhp
Copy link
Contributor Author

juhp commented Feb 2, 2025

This is just a cleanup PR so it is not urgent.

@chreekat
Copy link
Member

chreekat commented Feb 3, 2025

Actually I think it does still work. The link you gave in the PR description is a 404, but the individual package URLs are not.

E.g. https://www.stackage.org/lts-23.7/package/safe-0.3.21.tar.gz

@juhp
Copy link
Contributor Author

juhp commented Feb 3, 2025

Ah I see what you are saying: http://hackage.fpcomplete.com/package/safe-0.3.21.tar.gz does indeed work.

Though I am not sure, do we actually use it? Let me also try to check more later - this could be a bad idea.

@juhp juhp marked this pull request as draft February 3, 2025 10:56
@chreekat
Copy link
Member

chreekat commented Feb 3, 2025

It might be used by cabal-install if people use the Hackage mirror?

@chreekat
Copy link
Member

chreekat commented Feb 3, 2025

I don't see any .tar.gz URLs in the logs of the last two days, but I still think it might be a bad idea to remove a functional URL. It might break somebody, somewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants