This repository was archived by the owner on May 24, 2026. It is now read-only.
Fix extractReceiptVerb to read canonical receipt.verb with x402 fallback#27
Closed
GsCommand wants to merge 1 commit into
Closed
Fix extractReceiptVerb to read canonical receipt.verb with x402 fallback#27GsCommand wants to merge 1 commit into
GsCommand wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
extractReceiptVerbto read the canonicalreceipt.verbfield but the implementation only inspected legacyreceipt.x402.verb, causing CI failures.x402behavior as a fallback while making the canonical path authoritative per the Commons v1.1.0 contract.Description
extractReceiptVerbto delegate to the existinggetReceiptVerbso the function returnsreceipt.verbfirst and falls back toreceipt.x402.verbif needed (src/index.ts).ReceiptProtocolMetadatatype and fixed related type/generic usages and naming (receiptIdPresent,signerId) to resolve TypeScript errors (src/index.ts).verbfield so the testextractReceiptVerb reads canonical verb fieldvalidates the intended behavior (scripts/unit-tests.mjs).Testing
npm run typecheckand it completed successfully with no type errors.npm run buildand the build artifacts were produced successfully.npm run test:unitand all unit tests passed (44 passed, 0 failed).Codex Task