fix: use Ajv 2020 for trust schemas#44
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
$schema: "https://json-schema.org/draft/2020-12/schema", and runtime validation fails withno schema with key or ref "https://json-schema.org/draft/2020-12/schema"when using the default Ajv export.Description
Ajv2020fromajv/dist/2020and instantiate it vianew Ajv2020({ allErrors: true, strict: false })insrc/trust.ts.AddFormatstyping to acceptAjv2020and preserveajv-formatswiring by callingaddFormats(ajv)as before.ajv.addSchemaandajv.compile).src/trust.tswas modified to perform the switch to Ajv 2020.Testing
npm installwhich failed with a registry error403 Forbidden - GET https://registry.npmjs.org/ajv, so dependency installation did not complete and prevented further automated steps from running.npm run buildwas not executed becausenpm installfailed.npm testwas not executed becausenpm installfailed.Codex Task