fix: repair Ajv ESM imports in agent-sdk#41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
src/trust.tscaused by incorrect Ajv/ajv-formats import interop so schema validation compiles under ESM/TS environments.Description
src/trust.tsimports to use ESM/TypeScript-compatible forms: changedimport Ajv, { type ErrorObject } from "ajv";toimport { Ajv, type ErrorObject } from "ajv";and changedimport addFormats from "ajv-formats";toimport { default as addFormats } from "ajv-formats";with no changes to schemas or trust receipt/proof behavior.Testing
npm installwhich failed in this environment with403 Forbidden - GET https://registry.npmjs.org/ajvso dependencies could not be fetched.npm run buildwhich failed because dependencies and Node type declarations were unresolved (missingajv,ajv-formats,@types/node, and side-effect types likedotenv/config).npm testwhich failed because thepretestbuild step failed for the same dependency/type-resolution reasons.Codex Task