enable misra-c2012-2.5

commaai · Jun 8, 2024 · df66b33 · df66b33
1 parent b886883
commit df66b33
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml
@@ -103,7 +103,7 @@ jobs:
         timeout-minutes: 2
         run: ${{ env.RUN }} "cd tests/misra && CERT=./certs/debug RELEASE=1 ./test_misra.sh"
       - name: MISRA mutation tests
-        timeout-minutes: 5
+        timeout-minutes: 6
         run: ${{ env.RUN }} "cd tests/misra && pytest -n8 test_mutation.py"
 
   python_linter:

diff --git a/tests/misra/suppressions.txt b/tests/misra/suppressions.txt
@@ -18,7 +18,6 @@ unusedFunction:*/interrupt_handlers*.h
 # all of the below suppressions are from new checks introduced after updating
 # cppcheck from 2.5 -> 2.13. they are listed here to separate the update from
 # fixing the violations and all are intended to be removed soon after
-misra-c2012-2.5   # unused macros. a few legit, rest aren't common between F4/H7 builds. should we do this in the unusedFunction pass?
 misra-c2012-8.4
 misra-c2012-21.15
 

diff --git a/tests/misra/test_mutation.py b/tests/misra/test_mutation.py
@@ -37,6 +37,8 @@
 ]
 
 patterns = [
+  # misra-c2012-2.5
+  "$a #define TEST_2_5 1",
   # misra-c2012-8.7
   "$a extern void test_func_8_7(void); void test_func_8_7(void){;};",
   # misra-c2012-13.3