-
Notifications
You must be signed in to change notification settings - Fork 10.5k
ui: Fix scroll logic for non-scrollable content (bounds_size > content_size) to prevent jitter #36693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
466476b to
95746de
Compare
|
does this fix the wifi panel sometimes starting not at the top? i think there's also a problem where either the snapping or snap back doesn't land exactly at x/y=0 or max content width/height |
It might be caused by the large padding in the dialog layout. openpilot/selfdrive/ui/mici/widgets/dialog.py Line 321 in 946fd3f
|
|
That's to get it to roughly start at the middle. I think there's a bug somewhere in the Scroller |
|
This is fixed with #36705, lmk if this PR is for something else |
|
@sshane It’s unrelated to this issue, and the problem isn’t fixed yet. |
|
My bad, I was looking at the horizontal mis alignment in the screenshot. Is this ready? |
|
yes |



























Previously, the scroll panel could overshoot and jitter because the out-of-bounds logic assumed the content was always larger than the viewport. This bug affects the
OffroadAlertand Wifi list, causing invalid target offsets and incorrect snapping when the content is smaller than the viewport.Reproducing the bug:
UpdateAvailableand params/UpdaterNewReleaseNotes.