Skip to content

Conversation

@deanlee
Copy link
Contributor

@deanlee deanlee commented Nov 26, 2025

Previously, the scroll panel could overshoot and jitter because the out-of-bounds logic assumed the content was always larger than the viewport. This bug affects the OffroadAlert and Wifi list, causing invalid target offsets and incorrect snapping when the content is smaller than the viewport.

Reproducing the bug:

  1. Write params/UpdateAvailable and params/UpdaterNewReleaseNotes.
  2. Start the UI:
Screenshot 2025-11-26 23:51:32
  1. Drag the content — the alert notifier never returns to 0.0.
Screenshot 2025-11-26 23:51:48

@github-actions github-actions bot added the ui label Nov 26, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 26, 2025

raylib UI Preview

All Screenshots

@deanlee deanlee marked this pull request as ready for review November 27, 2025 06:16
@sshane
Copy link
Contributor

sshane commented Nov 27, 2025

does this fix the wifi panel sometimes starting not at the top?

i think there's also a problem where either the snapping or snap back doesn't land exactly at x/y=0 or max content width/height

@deanlee
Copy link
Contributor Author

deanlee commented Nov 27, 2025

does this fix the wifi panel sometimes starting not at the top?

i think there's also a problem where either the snapping or snap back doesn't land exactly at x/y=0 or max content width/height

It might be caused by the large padding in the dialog layout.

self._scroller = Scroller([], horizontal=False, pad_start=100, pad_end=100, spacing=0)

@sshane
Copy link
Contributor

sshane commented Nov 27, 2025

That's to get it to roughly start at the middle. I think there's a bug somewhere in the Scroller

@sshane
Copy link
Contributor

sshane commented Nov 27, 2025

This is fixed with #36705, lmk if this PR is for something else

@sshane sshane closed this Nov 27, 2025
@deanlee
Copy link
Contributor Author

deanlee commented Nov 27, 2025

@sshane It’s unrelated to this issue, and the problem isn’t fixed yet.

@sshane sshane reopened this Nov 27, 2025
@sshane
Copy link
Contributor

sshane commented Nov 27, 2025

My bad, I was looking at the horizontal mis alignment in the screenshot. Is this ready?

@deanlee
Copy link
Contributor Author

deanlee commented Nov 27, 2025

yes

@sshane sshane merged commit 6c39f6b into commaai:master Nov 29, 2025
10 of 11 checks passed
@deanlee deanlee deleted the ui-fix-scroll2 branch November 29, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants