Hyundai CAN: new gear shifter signal for EV, HEV, PHEV
#1530
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the vehicle is in manual or alternative drive modes (e.g., Sport), openpilot currently fails to recognize the signals and returns with an “Gear not D” event, exiting the controls.
Added Jupyter notebook for validating Sport gear for CAN hybrid and electric vehicles.
Solution
This pull request implements support for parsing various forward gear signals and adds additional undefined forward gear signals to the DBC.
Validation
EV, HEV, PHEV
openpilot#34113Reopen of
EV, HEV, PHEV
openpilot#30648Elect_Gear_Shifter
Sport Gear value #981