Toyota: simple long tuning improvement #1522
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Calculating jEgo and extrapolating into the future by the long actuator delay actually matches what the new tune does to avoid overshoot, without needing to compensate for issues with ACCEL_NET: Corolla w/ new tune on master on left. Corolla w/ this branch on right. Steep downhill:
Compare to before the new tune:
|
This reverts commit e73d60e.
This was referenced Nov 27, 2024
|
Done in #1559 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My goal is to ship a measurably improved long experience without regressing anything. Performance doesn't need to be perfect, just noticeably improved. This is becoming harder with the PCM acceleration request compensation stuff which is getting pretty complicated with all the filters and controllers.
This is an attempt to match the behavior of the new tune without relying on any not-fully-understood CAN signals.
Here's an example of the Corolla not braking enough on a down hill due to bad pitch, bad ACCEL_NET signal, and slow aEgo compensation: https://connect.comma.ai/a2bddce0b6747e10/00000503--6377595dba/154/209