-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toyota: improve new longitudinal tune #1491
base: master
Are you sure you want to change the base?
Conversation
nvm, hybrids respond so quickly that they overshoot the brake request right as it goes negative, and we want to learn the overshoot there with that high jerk. Instead, we'll low pass filter the PCM ACCEL_NET and then learn the offset on that, which should reduce overshoot and incorrect offset learning on both hybrid (fast brakes) and ICE (slow brakes) debug is pcm accel net, debug4 is filtered at 0.25s: Camry Hybrid: Lexus ES ICE: You can see here how we were requesting more deceleration because we thought it was undershooting, even though what it was applying was physically rate limited and it eventually overshooted |
Looking at 4 ICE and 4 hybrids maneuver reports from https://commaai.github.io/opendbc-data, it's clear that there's roughly a 2x increase in down jerk, so we might want a variable time constant for the ACCEL_NET filter to provide the best results on both platform variants. Up jerk looks mostly the same -1 m/s^2 step response means (ICE):
-1 m/s^2 step response means (hybrid):
|
This reverts commit ec410f5.
3974569
to
2921729
Compare
No description provided.