Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove VW footnote from website #1487

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Remove VW footnote from website #1487

merged 1 commit into from
Nov 14, 2024

Conversation

sshane
Copy link
Contributor

@sshane sshane commented Nov 14, 2024 •
edited
Loading

@jyoung8607 does VW_MQB_A0 make sense to also hide or no?

@sshane sshane marked this pull request as ready for review November 14, 2024 21:58
@github-actions github-actions bot added car related to opendbc/car/ volkswagen labels Nov 14, 2024
@sshane sshane merged commit d770f1b into master Nov 14, 2024
5 checks passed
@sshane sshane deleted the confusing-vw-fn branch November 14, 2024 21:59
@sshane
Copy link
Contributor Author

sshane commented Nov 14, 2024 •
edited
Loading

We can also remove this one entirely since we don't sell camera harness at this time, correct?

@jyoung8607
Copy link
Collaborator

jyoung8607 commented Nov 14, 2024 •
edited
Loading

CarFootnote VW_EXP_LONG is technically correct but admittedly confusing, and has outlived most (not all) of its use.

CarFootnote VW_MQB_A0 will go away when you ship #1296.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
car related to opendbc/car/ volkswagen
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sshane @jyoung8607