Add coin response type given sui rpc update#46
Open
theosudofi wants to merge 1 commit intocoming-chat:mainfrom
Open
Add coin response type given sui rpc update#46theosudofi wants to merge 1 commit intocoming-chat:mainfrom
theosudofi wants to merge 1 commit intocoming-chat:mainfrom
Conversation
zcqzcg
approved these changes
Mar 11, 2025
|
My team has also failing into this. |
zcqzcg
pushed a commit
to zcqzcg/go-sui-sdk
that referenced
this pull request
Mar 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With MystenLabs/sui#21137, the coin response type uses string instead of object id for cursor.
Hence, we need to update the page type to reflect that, else the client would run into unexpected bytes error.
Test: I updated existing test, also tested the patch with our go client.