Issue #76 Native pretty print#80
Issue #76 Native pretty print#80marklister wants to merge 1 commit intocom-lihaoyi:masterfrom marklister:prettytext3
Conversation
|
This pull request addresses issue #76. |
There was a problem hiding this comment.
Do we want the pretty-printer to leave these gaps between the tags? I'd rather it didn't.
There was a problem hiding this comment.
scala> div(
| p(float:="left")(
| "This is my first paragraph"
| ),
| a(tabindex:="10")(
| p("Goooogle")
| ),
| input(disabled:="true")
| ).pretty
res2: scalatags.text.Utils.Pretty =
<div>
<p style= "float: left;" > This is my first paragraph </p>
<a tabindex= "10" >
<p> Goooogle </p>
</a>
<input disabled= "true" />
</div>Does that look OK?
There was a problem hiding this comment.
@lihaoyi do you have a strong preference re combining tags on one line like this:
<p> Goooogle </p>
or do you think this is better:
<p>
Goooogle
</p>
My feeling is to go with the second.
|
I'll sort these out in the next day or two... |
|
@lihaoyi, see if this is a bit closer -- I don't mind fixing it again as many times as necessary. |
|
Uhm, this would be very nice. What happened to the PR please? |
|
@lihaoyi, I'm assuming this should be closed? |
|
@lihaoyi Could this be merged ? I would find also useful for pretty print. |
|
@lihaoyi, please merge |
|
@lihaoyi Would also very much like this feature merged if possible! |
|
Hello from 2020! |
|
@lolgab is this something that you'd accept? If so I'd be happy to rebase and get this up to date. |
|
@ckipp01 based on #76 (comment) I think it should be |
|
Or maybe #127 |
No description provided.