Prefer defaultResolver().resolveDeps over Lib.resolveDependencies #4727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
defaultResolver or millResolver (the latter being aware of the current build modules) defaultResolver automatically takes into account more resolution parameters that can be customized on CoursierModule / JavaModule, while calling Lib.resolveDependencies ignores them by default.
So that resolution logging goes to the task logger of the task requesting
the resolution, rather than the one of
`CoursierModule#{defaultResolver,millResolver}`
lefou
reviewed
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever possible, this tries to make modules defined in Mill use
CoursierModule#defaultResolverorCoursierModule#millResolverto resolve dependencies, rather than calling lower level helpers likeLib. resolveDependencies. The former automatically take into account customizations of resolution defined onCoursierModuleandJavaModule(repositoriesTask,mapDependencies, etc.), while these have to be passed manually toLib.resolveDependencies.This helps when adding more parameters - these have to be passed to
defaultResolver/millResolver, and that's it, rather than also having to inspect all calls toLib.resolveDependencies, and passing the new parameter there too.This also tries to make resolution log to the task logger of the task requesting the resolution, rather than the logger of
CoursierModule#{defaultResolver,millResolver}.