Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the organization name and url/homepage members to PomSettings #4654

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ShreckYe
Copy link
Contributor

@ShreckYe ShreckYe commented Mar 5, 2025

The PomSettings.organization member corresponds to a Maven group. The organization name and url properties are available in Maven, Gradle, and sbt. Shall we add them in PomSettings for Mill too?

I haven't added the organizationUrl/organizationHomepage member yet as I am not sure whether we stick to the former name (more similar to Maven and Gradle's) or the latter (consistent with sbt). I have added a backward-comaptible companion object apply method for the code to work with minimal modification and haven't updated the callers or the conversion buildgen code yet.

@lihaoyi
Copy link
Member

lihaoyi commented Mar 13, 2025

Not sure i understand this PR; what's the difference between organization and organizationName?

@ShreckYe
Copy link
Contributor Author

ShreckYe commented Mar 13, 2025

From sbt's corresponding setting keys:

  val organization = settingKey[String]("Organization/group ID.").withRank(APlusSetting)
  val organizationName = settingKey[String]("Organization full/formal name.").withRank(BMinusSetting)
  val organizationHomepage = settingKey[Option[URL]]("Organization homepage.").withRank(BMinusSetting)

From their docs:

organization := "org.example"
organizationHomepage := Some(url("http://example.org"))
homepage := Some(url("https://www.scala-sbt.org"))

@lefou
Copy link
Member

lefou commented Mar 13, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants