-
-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BOM support #3924
base: main
Are you sure you want to change the base?
Add BOM support #3924
Conversation
Sir @alexarchambault, will this add bom support for jetpack compose libs also? |
If it only relies on a "BOM", that should yes. But this PR isn't about the Gradle module metadata stuff, that was mentioned too in one of your PRs. |
Actually i think this will work(not sure) lets see after it gets merged then i will try this once |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we need to take transitive bomDeps
into account? In it's current draft, bomDeps
is only used intransitively.
As a rule of thumb, transitive moduleDeps
should behave the same as transitive ivyDeps
. If an upstream dependency import a BOM and that BOM is considered by coursier when resolving dependencies, it should also work, if that upstream dependency is a local module.
@lefou Yes, that's what I meant by "make things working for multi-module projects". In the ITs, I intend to publish locally things in a directory, and check that resolution by coursier of stuff published locally gives the same class path as Mill computes internally. |
Work in progress, got to check that the published modules are fetched correctly by coursier (checking that it takes the BOMs into accounts), make things working for multi-module projects, maybe add direct dependency management and BOM generation capabilities, …