Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward javacOptions to JMH #3578

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Forward javacOptions to JMH #3578

merged 1 commit into from
Sep 19, 2024

Conversation

Quafadas
Copy link
Contributor

@Quafadas Quafadas commented Sep 18, 2024

I believe this to be a solution for #3576 . However, I'm unclear how I could effectively test it. Feedback welcomed.

@lihaoyi
Copy link
Member

lihaoyi commented Sep 18, 2024

@Quafadas I think manual testing is fine for this. Presumably you are able to reproduce the original reported issue, and can use installLocalCache to see if your PR fixes it?

@Quafadas
Copy link
Contributor Author

Quafadas commented Sep 19, 2024

The original issue I could reproduce easily. In the issue I left a comment which was a workaround, where I copy pasted overrode the method in my local build, and that fixed the issue.

I’m afraid I don’t understand the installLocalCache part of your comment, apologies?

@lihaoyi
Copy link
Member

lihaoyi commented Sep 19, 2024

Oh I meant that you could use it for manual testing: it generates a local mill binary with all thee stuff publishLocaled for you to try out. But if the override works in your local build, I think that's enough confidence for me

@lihaoyi lihaoyi merged commit 92a7211 into com-lihaoyi:main Sep 19, 2024
24 checks passed
@lefou lefou added this to the 0.12.0 milestone Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants