-
-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Implement support for *HyAB* large color difference. #1305
Conversation
I think I got the implementation correct, but could somebody double check the other stuff: documentation, tests, citation, formatting, etc.? I'm not sure I got all the tests to run correctly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @mesvam,
I added a few important comments, what about also adding cbLAB
? Would be great!
Cheers,
Thomas
I just noticed there are functions for |
I don't mind adding cbLAB if you like, as well as some of the other metrics in that paper, but the authors recommended HyAB and HyCH as the top candidates. We can also add all four formulas, but maybe that's too much or too confusing. Also, would you prefer that in a separate PR, or just tack it onto this one? |
Ok, I'm stumped. How do I pass Codacy? I can't seem to find the error messages |
If you can wherever possible, this would be fantastic! I would probably try to get HyCH actually if you please don't mind:
Do not worry, it is all good atm! |
I submitted a separate PR for HyCH #1307 |
On second thought, I think using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Merging this one!
Summary
Implement HyAB color difference and resolves #610
Preflight
Code Style and Quality
colour
,colour.models
.Documentation