Skip to content
This repository was archived by the owner on Mar 27, 2025. It is now read-only.

Simplify export method in importexport.py#51

Open
ironmaniiith wants to merge 1 commit intomasterfrom
simplify-export
Open

Simplify export method in importexport.py#51
ironmaniiith wants to merge 1 commit intomasterfrom
simplify-export

Conversation

@ironmaniiith
Copy link
Copy Markdown
Contributor

For more reference see this discussion: #50 (comment)

For more reference see this discussion: #50 (comment)
@ironmaniiith
Copy link
Copy Markdown
Contributor Author

@djay , I think I've found the reason why this behaviour existed in the very first place. So the way the current export happens is, we check a bunch of checkboxes and select which all fields to have in the metadata. In these checkboxes options, 'type', 'id', 'uid', and 'path' are not there, but seems like they are a necessary component if we have to support an import functionality for the existing content.
Can you clear if this was the reason why you implemented it in this way @Shriyanshagro ?
If this is the case, then maybe we can keep this appending the mandatory fields for now and can think about this PR later.

@djay
Copy link
Copy Markdown
Member

djay commented Jun 26, 2019

@ironmaniiith its a misunderstanding of the original requirements. The system is meant for 2 purposes. import/export within plone and import/export with external systems. What you use as a primary key will depend on the purpose. All fields should be optional but with sensible defaults.
Also I think its simpler to have id and path be the same thing since the id is in the path.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants