-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better Plone 4 / Python 2 compatibility #233
Conversation
The original author information should be at the end and not somewhere in between.
install_requires.append("plone.restapi < 8") | ||
install_requires.append("plone.schema < 2") | ||
install_requires.append("PyJWT < 2") | ||
install_requires.append("pyrsistent < 0.16.0") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks to me like you're adding pins for Plone 4, but doing it based on the presence of Python 2. It is also possible to use Python 2 with Plone 5.1 and 5.2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested only in Plone 4.
But above these thresholds there is only Python 3 support - also for plone.schema, plone.restapi and plone.api.
I think this should be safe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thet I think you are right.
I take that as a go :D |
@thet weird, since this merge this packages main page does not render anymore in github, same for forks.
|
The issue has gone away :) |
Wow, great :) @flipmcf issue looks like if you got a Python 2 incompatible package, actually the kind of problem my PRs here should have fixed. The other issue - I updated the README - maybe I created an .rst error. |
When I tried to install this package in Plone 4 it took me some time to get the versions straight. It would have saved me some time if I had read the Plone 4 install section in the README, but I didn't and it is well hidden.
I think having an easy installation experience in Plone 4 with Python 2 is quite important for this package as this is probably a frequent use case.
This PR should fix that out of the box and improve the README a bit, as of the time of this writing. There is a good chance that it will break again, however, for now it does work fine.
/cc @canepan