Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix KeyError: time on import with workflow without time variable #232

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Fix KeyError: time on import with workflow without time variable #232

merged 1 commit into from
Nov 30, 2023

Conversation

mauritsvanrees
Copy link
Member

Fixes #222

@mauritsvanrees mauritsvanrees requested a review from zopyx November 30, 2023 11:26
zopyx
zopyx approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@zopyx zopyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly correct 😁
I don't have the usecase anymore since the customer wants this information to be discarded during our migration imports :-)

@zopyx zopyx merged commit 8e4c1cf into main Nov 30, 2023
11 checks passed
@zopyx zopyx deleted the maurits-keyerror-time-workflow branch November 30, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zopyx zopyx zopyx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

KeyError: 'time' for history_item
2 participants
@mauritsvanrees @zopyx