Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add principals to groups that already exist during import #229

Merged
merged 1 commit into from
Nov 11, 2023
Merged

Add principals to groups that already exist during import #229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGES.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ Changelog
- Add support for ATTopic export_content
[avoinea]

- Add principals to groups that already exist during import (#228)
[pbauer]

1.10 (2023-10-11)
-----------------
Expand Down
6 changes: 3 additions & 3 deletions src/collective/exportimport/import_other.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,10 +222,10 @@ def import_groups(self, data):
description=item["description"],
roles=item["roles"],
)
# add all principals
for principal in item.get("principals", []):
pg.addPrincipalToGroup(principal, item["groupid"])
groupsNumber += 1
# add all principals, even if they are not stored in plone (e.g. LDAP)
for principal in item.get("principals", []):
pg.addPrincipalToGroup(principal, item["groupid"])
return groupsNumber

def import_members(self, data):
Expand Down