Fix GHA 2.7 support #214
Merged
Fix GHA 2.7 support #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gotcha
force-pushed
the
fix_gha
branch
3 times, most recently
from
8b7ec66 to
4597548
Compare
gotcha
force-pushed
the
fix_gha
branch
11 times, most recently
from
49d68eb to
541d558
Compare
|
What about the approach used here: actions/setup-python#672 (comment) |
|
Cool, this seems to work now. Thanks for that! Using the image plone/test-with-tox for the 2.7 tests is fine with me. |
|
@gotcha is that ready to be reviewed/merged? |
|
I just wanted to use the same approach on another repo to see if it still needed to be improved before merging. Should be this week. |
|
@gotcha ready to merge now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.