Skip to content

Commit

Permalink
Merge pull request #244 from collective/export-namedimage-blobpaths
Browse files Browse the repository at this point in the history
Fix `AtributeError: 'NamedImage' object has no attribute '_blob'`
  • Loading branch information
pbauer authored Nov 12, 2024
2 parents 365c6c7 + 342c20a commit e1fada2
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 1 deletion.
2 changes: 2 additions & 0 deletions CHANGES.rst
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ Changelog

- Add and run a black version, that is compatible with Python 2.
[pgrunewald]
- Fix ``AtributeError: 'NamedImage' object has no attribute '_blob'`` similar to #236.
[petschki]

- Make zcml conditions more specific so that migration aliases don't trigger them
[reinhardt]
Expand Down
2 changes: 2 additions & 0 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@
install_requires.append("jsonschema < 4")
install_requires.append("pathlib2")
install_requires.append("plone.api >= 1.8.4, < 2")

install_requires.append("ijson < 3.3.0")
# There is a py2-imcompatibility in plone.rest 3.0.1
install_requires.append("plone.rest < 3.0.1")
install_requires.append("plone.restapi < 8")
Expand Down
11 changes: 10 additions & 1 deletion src/collective/exportimport/serializer.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
from hurry.filesize import size
from plone.app.textfield.interfaces import IRichText
from plone.dexterity.interfaces import IDexterityContent
from plone.namedfile.interfaces import INamedFileField, INamedBlobFileField
from plone.namedfile.interfaces import INamedFileField, INamedBlobFileField, INamedImageField, INamedBlobImageField
from plone.namedfile.interfaces import INamedImageField
from plone.restapi.behaviors import IBlocks
from plone.restapi.interfaces import IFieldSerializer
Expand Down Expand Up @@ -619,6 +619,15 @@ def __call__(self):

@adapter(INamedImageField, IDexterityContent, IPathBlobsMarker)
@implementer(IFieldSerializer)
class ImageFieldSerializerZODBData(ImageFieldSerializerWithBlobs):
"""Although the marker is IPathBlobsMarker, this being a plain NamedImage
object, its data is in the ZODB, thus this still needs to be
base64 encoded into the JSON file
So we just subclass from the above ImageFieldSerializerWithBlobs"""


@adapter(INamedBlobImageField, IDexterityContent, IPathBlobsMarker)
@implementer(IFieldSerializer)
class ImageFieldSerializerWithBlobPaths(DefaultFieldSerializer):
def __call__(self):
image = self.field.get(self.context)
Expand Down

0 comments on commit e1fada2

Please sign in to comment.