Merge pull request #229 from collective/add_principals_to_existing_gr…

…oups
collective · Nov 11, 2023 · d3946d8 · d3946d8
2 parents f92eeca + 79d1541
commit d3946d8
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/CHANGES.rst b/CHANGES.rst
@@ -12,6 +12,8 @@ Changelog
 - Add support for ATTopic export_content
   [avoinea]
 
+- Add principals to groups that already exist during import (#228)
+  [pbauer]
 
 1.10 (2023-10-11)
 -----------------

diff --git a/src/collective/exportimport/import_other.py b/src/collective/exportimport/import_other.py
@@ -222,10 +222,10 @@ def import_groups(self, data):
                     description=item["description"],
                     roles=item["roles"],
                 )
-                # add all principals
-                for principal in item.get("principals", []):
-                    pg.addPrincipalToGroup(principal, item["groupid"])
                 groupsNumber += 1
+            # add all principals, even if they are not stored in plone (e.g. LDAP)
+            for principal in item.get("principals", []):
+                pg.addPrincipalToGroup(principal, item["groupid"])
         return groupsNumber
 
     def import_members(self, data):