DRYD-1989 > Search (New) > Structured date field group is not blank returns all records #310
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
OP_NULL,OP_NOT_NULLto an nxql condition that checks if all fields are null/not null. Except thescalarvaluescomputedfield which isfalseby default.collectionobjects_common:assocDateGroupList/*/assocStructuredDateGroup. This case was ignored before the fix because correlation checked if the nxqlPath ends with wildcard: https://github.com/collectionspace/cspace-ui.js/pull/310/changes#diff-5785c6e3d60833bc1054cff731c6d54a1107c5f56b2f99220f10729f14410418L647 leading to uncorrelated paths (wildcards are not numbered).Why are we doing this? (with JIRA link)
We want to support is blank/is not blank operators for structured dates. We also should fix the issue of missing correlations: https://collectionspace.atlassian.net/browse/DRYD-1989
How should this be tested? Do these changes have associated tests?
Testing is blank/is not blank operator of structured dates.
Please create a collection object with a structured date. Using the new advanced search, search by that structured date applying the is not blank operator. The object should be included in the results. Then edit the collection object, delete the structured date and search using the is blank operator. Confirm that the object is included in the results.
Testing the correlation fix.
instead of this:
Dependencies for merging? Releasing to production?
No dependencies
Has the application documentation been updated for these changes?
We will need to update the documentation
Did someone actually run this code to verify it works?
@spirosdi ran it locally.