Skip to content

Conversation

@mikejritter
Copy link
Contributor

@mikejritter mikejritter commented Jan 8, 2026

What does this do?

  • Fixes not found image text (No Preview Image Available)
  • Fixes prefix text for concept tags (CONCEPT TAGS)
  • Use formatRefNameWithDefault to handle fields which might be refs
  • Update agent and field collector formatters to display iff non-date fields are present
  • Add tests for detailList configuration

Why are we doing this? (with JIRA link)
Jira: https://collectionspace.atlassian.net/browse/DRYD-1938?

These are changes requested from QA as there were some differences in the text as well as the behavior in some of the logic due to de-urning failures.

How should this be tested? Do these changes have associated tests?

  • Run the devserver, e.g. npm run devserver --back-end=https://core.dev.collectionspace.org
  • Search for Object and switch to the 'list' view
  • See that the following changes exist:
    • The preview text is updated for images which don't exist
    • Objects with contentConcepts should display CONCEPT TAGS
    • Objects with only field collectors should correctly display (field collector)

Dependencies for merging? Releasing to production?
I'm wondering if we should i18n the (field collector) part now as it is being passed from the server with no option otherwise.

Has the application documentation been updated for these changes?
No, as these updates are being done in order to match the documentation.

Did someone actually run this code to verify it works?
@mikejritter has been testing using core.dev as a backend

@mikejritter mikejritter marked this pull request as ready for review January 15, 2026 20:27
@mikejritter mikejritter requested a review from spirosdi January 15, 2026 20:29
Copy link

@spirosdi spirosdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, regarding "(field collector)" i18n, I am not sure either. @jessiweithman what do you think?

Comment on lines 150 to 152
id="detailList.collectionobject.concepts"
description="The prefix for content concept tags in the search detail view"
defaultMessage="Content Concepts: "
defaultMessage="CONCEPT TAGS: "

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please intl this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spirosdi I added a messages object to each formatter which uses any text which needs to be i18n'd and allows the messages to show up when we run generateDocs.js. Though this did make me question whether or not we should just pass the intl object to the formatters instead of relying on FormattedMessage. Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants