Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the package package override checks out of colcon-core #476

Merged
merged 2 commits into from
Apr 12, 2022

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented Jan 27, 2022

This functionality is being moved to a separate colcon extension, colcon-override-check.

Reverts part of #449

This functionality is being moved to a separate colcon extension,
colcon-override-check.
@cottsay cottsay requested a review from sloretz January 27, 2022 23:55
@cottsay cottsay self-assigned this Jan 27, 2022
@codecov
Copy link

codecov bot commented Jan 27, 2022

Codecov Report

Merging #476 (85e4671) into master (64f06cf) will increase coverage by 0.66%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #476      +/-   ##
==========================================
+ Coverage   81.11%   81.77%   +0.66%     
==========================================
  Files          59       59              
  Lines        3569     3540      -29     
  Branches      687      676      -11     
==========================================
  Hits         2895     2895              
+ Misses        628      599      -29     
  Partials       46       46              
Impacted Files Coverage Δ
colcon_core/verb/build.py 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64f06cf...85e4671. Read the comment docs.

Copy link
Contributor

@sloretz sloretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when the replacement is merged

@cottsay
Copy link
Member Author

cottsay commented Mar 21, 2022

I'm holding this PR until colcon/colcon-common-extensions#15 is merged, which itself is waiting until I have sufficient privileges to release that package.
Merging this prematurely could mean that either we're without override checks or blocking colcon-core releases until colcon-common-extensions can be released.

@cottsay cottsay added this to the 0.7.2 milestone Apr 11, 2022
@cottsay cottsay merged commit dd7b335 into master Apr 12, 2022
@delete-merged-branch delete-merged-branch bot deleted the cottsay/move-override-check branch April 12, 2022 00:23
esteve pushed a commit to esteve/colcon-core that referenced this pull request Apr 26, 2022
This functionality is being moved to a separate colcon extension,
colcon-override-check.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants