Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup find_installed_packages to fix bootstrap instructions #472

Merged
merged 4 commits into from
Jan 22, 2022

Conversation

sloretz
Copy link
Contributor

@sloretz sloretz commented Jan 21, 2022

Fix an issue from #449 - the bootstrap from source instructions are failing with the following error

[0.267s] ERROR:colcon.colcon_core.shell:Exception in shell extension 'sh': get_entry_points() not overridden for group 'colcon_core.shell.find_installed_packages'
Traceback (most recent call last):
  File "/home/sloretz/ws/colcon-from-source/src/colcon-core/colcon_core/shell/__init__.py", line 298, in get_command_environment
    return await extension.generate_command_environment(
  File "/home/sloretz/ws/colcon-from-source/src/colcon-core/colcon_core/shell/sh.py", line 137, in generate_command_environment
    check_dependency_availability(
  File "/home/sloretz/ws/colcon-from-source/src/colcon-core/colcon_core/shell/__init__.py", line 510, in check_dependency_availability
    packages_in_env = find_installed_packages_in_environment()
  File "/home/sloretz/ws/colcon-from-source/src/colcon-core/colcon_core/shell/__init__.py", line 552, in find_installed_packages_in_environment
    pkgs = find_installed_packages(prefix_path)
  File "/home/sloretz/ws/colcon-from-source/src/colcon-core/colcon_core/shell/__init__.py", line 621, in find_installed_packages
    prioritized_extensions = get_find_installed_packages_extensions()
  File "/home/sloretz/ws/colcon-from-source/src/colcon-core/colcon_core/shell/__init__.py", line 601, in get_find_installed_packages_extensions
    extensions = instantiate_extensions(__name__ + '.find_installed_packages')
  File "/home/sloretz/ws/colcon-from-source/src/colcon-core/colcon_core/plugin_system.py", line 36, in instantiate_extensions
    extension_types = load_entry_points(
  File "./src/colcon-core/bin/colcon", line 28, in custom_load_entry_points
    assert group_name in custom_entry_points, \
AssertionError: get_entry_points() not overridden for group 'colcon_core.shell.find_installed_packages'

I thought CI covered the bootstrap case, so I'm not sure why this wasn't caught.

@sloretz sloretz added the bug Something isn't working label Jan 21, 2022
@sloretz sloretz requested a review from cottsay January 21, 2022 21:51
@sloretz sloretz self-assigned this Jan 21, 2022
Signed-off-by: Shane Loretz <[email protected]>
@codecov
Copy link

codecov bot commented Jan 21, 2022

Codecov Report

Merging #472 (4974d35) into master (49051fc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #472   +/-   ##
=======================================
  Coverage   80.81%   80.81%           
=======================================
  Files          59       59           
  Lines        3518     3518           
  Branches      668      668           
=======================================
  Hits         2843     2843           
  Misses        630      630           
  Partials       45       45           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49051fc...4974d35. Read the comment docs.

Copy link
Member

@cottsay cottsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, can you make the addition to the dict alphabetical?

Signed-off-by: Shane Loretz <[email protected]>
@sloretz
Copy link
Contributor Author

sloretz commented Jan 22, 2022

@cottsay Oops, alphabetical order in c701499

@sloretz sloretz requested a review from cottsay January 22, 2022 01:19
@cottsay cottsay merged commit 76b0a24 into master Jan 22, 2022
@delete-merged-branch delete-merged-branch bot deleted the sloretz__fix_bootstrap_find_installed_packages branch January 22, 2022 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

2 participants