Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graceful shutdown #22

Merged
merged 27 commits into from
Aug 9, 2024
Merged

Graceful shutdown #22

merged 27 commits into from
Aug 9, 2024

Conversation

ignaciogoldchluk-yolo
Copy link
Contributor

@ignaciogoldchluk-yolo ignaciogoldchluk-yolo commented Aug 6, 2024 •
edited
Loading

  • Start ConnectionServer before ConsumerSupervisor
  • Keep channels in ConnectionServer state, pass a reference to the consumers
  • Close channels before closing connection when terminating ConnectionServer
  • Add logs, Mermaid diagram, tests and documentation

yolo-vikram
yolo-vikram reviewed Aug 7, 2024
View reviewed changes
lib/coney/connection_server.ex Outdated Show resolved Hide resolved
lib/coney/connection_server.ex Outdated Show resolved Hide resolved
lib/coney/connection_server.ex Show resolved Hide resolved
yolo-vikram
yolo-vikram reviewed Aug 8, 2024
View reviewed changes
test/support/fake_consumer.ex Show resolved Hide resolved
lib/coney/connection_server.ex Show resolved Hide resolved
lib/coney/connection_server.ex Show resolved Hide resolved
yolo-vikram
yolo-vikram approved these changes Aug 8, 2024
View reviewed changes
Copy link
Collaborator

@yolo-vikram yolo-vikram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall Looks good! 🚀
Few minor comments.

@ignaciogoldchluk-yolo ignaciogoldchluk-yolo merged commit 953760e into main Aug 9, 2024
1 check passed
@ignaciogoldchluk-yolo ignaciogoldchluk-yolo deleted the graceful_shutdown branch August 9, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yolo-vikram yolo-vikram yolo-vikram approved these changes

@edgarmiadzieles edgarmiadzieles edgarmiadzieles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ignaciogoldchluk-yolo @edgarmiadzieles @yolo-vikram