Allow setting credentials as lambda #254
Open
+23
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egletam
approved these changes
Jul 4, 2023
|
@lorines I don't know, it is up to the library maintainers. |
|
Hey @antstorm anyone willing to take a look at this? |
GalenkoEugene
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a problem with multiple Puma workers and preload, because Temporal initializer which configures connection credentials ran before fork. Therefore after fork it we got an error:
Reconfiguring credentials after forking does not work because of the guard in grpc gem:
https://github.com/grpc/grpc/blob/e20e7a1198b2ff276a2f4f8514201b8ac1456830/src/ruby/ext/grpc/rb_grpc.c#L264
There is an old issue about it: grpc/grpc#8798
Therefore the most elegant solution was to configure credentials on demand, when connection is being built (after fork).
I have added a lambda support to solve this issue. It works for us.
@egletam