Count Workflow Executions #203
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antstorm
suggested changes
Nov 2, 2022
lib/temporal.rb
Outdated
| @@ -29,7 +29,8 @@ module Temporal | |||
| :fail_activity, | |||
| :list_open_workflow_executions, | |||
| :list_closed_workflow_executions, | |||
| :query_workflow_executions | |||
| :query_workflow_executions, | |||
| count_workflow_executions | |||
There was a problem hiding this comment.
This looks like a syntax error 👁️
lib/temporal/client.rb
Outdated
| @@ -409,6 +409,10 @@ def query_workflow_executions(namespace, query, next_page_token: nil, max_page_s | |||
| Temporal::Workflow::Executions.new(connection: connection, status: :all, request_options: { namespace: namespace, query: query, next_page_token: next_page_token, max_page_size: max_page_size }.merge(filter)) | |||
| end | |||
|
|
|||
| def count_workflow_executions(namespace, query) | |||
There was a problem hiding this comment.
I don't think that other SDKs actually have this method exposed. With that in mind, let's not add it to the Client, but instead only expose it on the connection itself and possibly make the connection public. This way you can access the low-level API if needed, but we're not committing to supporting it via the high-level classes
| namespace: namespace, | ||
| query: query | ||
| ) | ||
| client.count_workflow_executions(request) |
There was a problem hiding this comment.
wait, this is also missing an end. Something is not right with this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes implements the count_workflow_executions function and adds an integration test to check this works!
Test Plan