Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow clients to configure gRPC client interceptors #185

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

christopherb-stripe
Copy link
Contributor

gRPC interceptors can be useful for adding common behavior and setting metadata for any interim service routing or proxies. This PR allows for clients to configure interceptors that will be executed as part of the request.

I'm not sold on the configuration for this as it will only apply to gRPC interceptors but it currently lives in the global configuration. Do you have a preference on how to expose connection type specific configuration?

I've added an integration test that shows the interface and provides a simple example.

What do you think?

@christopherb-stripe
Copy link
Contributor Author

Hmm, the integration test passes consistently locally on my machine. I'm not sure what's causing the failure here. I thought it could be that the client was being memoized without interceptors somewhere in the library but I would expect that to reproduce locally too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant