Some miscellaneous updates after bug bash #26
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drohit-cb
force-pushed
the
updates_after_bug_bash
branch
from
25efb8d to
1ae23b0
Compare
ProfMoo
reviewed
May 9, 2024
| @@ -7,7 +7,7 @@ | |||
| "scripts": { | |||
| "clean": "rimraf ./dist", | |||
| "gen": "npm run clean-gen && ./scripts/generate-client.sh", | |||
| "clean-gen": "rm -rf src/gen/* && rm -rf docs/openapi/*", | |||
There was a problem hiding this comment.
Do we intend to keep orchestration.swagger.json in the case we don't remove the docs during each generation?
There was a problem hiding this comment.
oops missed the orchestration swagger somehow..
will close this PR and open a separate one
marcin-cb
approved these changes
May 9, 2024
deangalvin-cb
requested changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Change
This PR helps:
Testing Procedure