update TransferIntent id type to bytes32 by kylekaplan · Pull Request #18 · coinbase/commerce-onchain-payment-protocol

kylekaplan · 2024-08-05T23:51:57Z

Hi,

I was wondering if the id field of the TransferIntent could be updated to a bytes32 instead of bytes16.

This would make it so the Keccak256 hash function could be used to generate predictable ids and be more compatible with other protocols generating ids with Keccak256.

For my use case, I'm using EAS (Ethereum Attestation Service) as a backend to create an on-chain eCommerce solution, and it would be nice if I could use an attestation UID (a Keccak256 hash of the attestation) as the id for the TransferIntent. This would make the relationship between an attestation and a TransferIntent simpler and more efficient.

Thanks for your consideration and for this awesome protocol.

cb-heimdall · 2024-08-05T23:52:04Z

🟡 Heimdall Review Status

Requirement Status More Info

Reviews

🟡 0/1

Denominator calculation

Show calculation

1 if user is bot 0

1 if user is external 0

From .codeflow.yml 1

Additional review requirements

Show calculation

Max	0

0

From CODEOWNERS 0

Global minimum 0

Max 1

1

1 if commit is unverified 1

Sum 2

nichechristie · 2024-08-06T00:18:56Z

Agreed

TELLYWHALE

🐳

cb-heimdall · 2024-08-11T00:05:58Z

Review Error for TELLYWHALE @ 2024-08-11 00:05:58 UTC
User must have write permissions to review

TELLYWHALE

🤞🏾

cb-heimdall · 2024-08-11T00:30:59Z

Review Error for TELLYWHALE @ 2024-08-11 00:30:59 UTC
User must have write permissions to review

nichechristie

Permissions

cb-heimdall · 2024-08-27T21:09:33Z

Review Error for Nichebiche @ 2024-08-27 21:09:33 UTC
User must have write permissions to review

nichechristie

Requesting write access

cb-heimdall · 2024-09-21T22:09:21Z

Review Error for MTerrases22 @ 2024-09-21 22:09:21 UTC
User must have write permissions to review

nichechristie · 2024-09-21T22:10:44Z

Does this mean I now have write access and permissions ? Sent from Yahoo Mail for iPhone On Saturday, September 21, 2024, 6:09 PM, Heimdall ***@***.***> wrote: Review Error for MTerrases22 @ 2024-09-21 22:09:21 UTC User must have write permissions to review — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: ***@***.***>

nichechristie

I hope this means I have write access now. Just learning over here:)

cb-heimdall · 2024-09-21T22:14:21Z

Review Error for Nichebiche @ 2024-09-21 22:14:21 UTC
User must have write permissions to review

cb-heimdall · 2024-09-21T22:43:13Z

Review Error for Irasone @ 2024-09-21 22:43:13 UTC
User must have write permissions to review

cb-heimdall · 2024-09-21T22:44:29Z

Review Error for Irasone @ 2024-09-21 22:44:29 UTC
User must have write permissions to review

MTerrases22 · 2024-09-23T19:29:15Z

Why haven't I received payment? I've been mistreated here. This is my account and no one should be preventing me from it. I'm so not letting this one go . I can't retrieve my funds. Someone took my identity and keeps locking me out of my account. I want my account left alone. It's my money not anyone else's.

Sturgeontara06

Sure

MTerrases22 · 2024-10-11T00:47:41Z

What am I supposed to do with this Get Outlook for Android<https://aka.ms/AAb9ysg>

…

________________________________ From: Sturgeontara06 ***@***.***> Sent: Thursday, October 10, 2024 5:17:24 PM To: coinbase/commerce-onchain-payment-protocol ***@***.***> Cc: Marlyn Elizabeth Terrases ***@***.***>; Comment ***@***.***> Subject: Re: [coinbase/commerce-onchain-payment-protocol] update TransferIntent id type to bytes32 (PR #18) @Sturgeontara06 commented on this pull request. Sure — Reply to this email directly, view it on GitHub<#18 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BKBCEVRTDEKIT4I26JEKKLTZ24KJJAVCNFSM6AAAAABMBGYTBKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGNRRGY2TMNJVGU>. You are receiving this because you commented.Message ID: ***@***.***>

cb-heimdall · 2024-10-11T01:46:05Z

Review Error for Irasone @ 2024-10-11 01:46:04 UTC
User must have write permissions to review

MTerrases22 · 2024-10-12T13:28:13Z

Please check now. Was this taken care of?

…

On Thu, Oct 10, 2024 at 6:46 PM Heimdall ***@***.***> wrote: Review Error for Irasone @ 2024-10-11 01:46:04 UTC User must have write permissions to review — Reply to this email directly, view it on GitHub <#18 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BKBCEVV2W734MHHH7XEHXZDZ24UXFAVCNFSM6AAAAABMBGYTBKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBWGM3TGMJWGI> . You are receiving this because you commented.Message ID: ***@***.*** com>

-- *Marlyn E.Terrases*

MTerrases22 · 2024-10-12T13:28:55Z

Awesome, thank you so much!

…

On Thu, Oct 10, 2024 at 6:46 PM Irasone ***@***.***> wrote: ***@***.**** approved this pull request. — Reply to this email directly, view it on GitHub <#18 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BKBCEVU2SJTN3OIAJ43B5MLZ24UW5AVCNFSM6AAAAABMBGYTBKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGNRRG42TSMRSGQ> . You are receiving this because you commented.Message ID: <coinbase/commerce-onchain-payment-protocol/pull/18/review/2361759224@ github.com>

-- *Marlyn E.Terrases*

MTerrases22 · 2024-10-14T21:58:42Z

How can I access that check. With authorization of course. Been locked out and unable to claim my assets.someone please help me.

MTerrases22 · 2024-10-20T19:56:09Z

Hello, I haven't been getting my emails.

…

On Sat, Sep 21, 2024 at 3:44 PM Heimdall ***@***.***> wrote: Review Error for Irasone @ 2024-09-21 22:44:29 UTC User must have write permissions to review — Reply to this email directly, view it on GitHub <#18 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BKBCEVT74XR3KDXOWRJQ76DZXXZGHAVCNFSM6AAAAABMBGYTBKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRVGM2DKMBZGE> . You are receiving this because you commented.Message ID: ***@***.*** com>

-- *Marlyn E.Terrases*

cb-heimdall · 2024-10-24T07:38:24Z

Review Error for Tinaochoa8462 @ 2024-10-24 07:38:24 UTC
User must have write permissions to review

cb-heimdall · 2024-11-07T11:33:52Z

Review Error for joeltato @ 2024-11-07 11:33:52 UTC
User must have write permissions to review

joeltato · 2024-11-07T11:41:09Z

how get my funds

…

On Thu, Nov 7, 2024 at 5:34 AM Heimdall ***@***.***> wrote: Review Error for joeltato @ 2024-11-07 11:33:52 UTC User must have write permissions to review — Reply to this email directly, view it on GitHub <#18 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BMUM4PVE4A55VG7KR4S35DTZ7NF3NAVCNFSM6AAAAABMBGYTBKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRSGAYDKNJZGQ> . You are receiving this because you commented.Message ID: ***@***.*** com>

cb-heimdall · 2024-12-06T22:54:24Z

Review Error for zwiux42 @ 2024-12-06 22:54:23 UTC
User must have write permissions to review

zwiux42

🤝🏽

cb-heimdall · 2024-12-07T01:08:15Z

Review Error for zwiux42 @ 2024-12-07 01:08:15 UTC
User must have write permissions to review

cb-heimdall · 2024-12-08T10:51:13Z

Review Error for Irasone @ 2024-12-08 10:51:13 UTC
User must have write permissions to review

cb-heimdall · 2024-12-08T10:52:46Z

Review Error for Irasone @ 2024-12-08 10:52:46 UTC
User must have write permissions to review

justpayme3 · 2025-01-23T21:28:26Z

contracts/interfaces/ITransfers.sol

@@ -23,7 +23,7 @@ struct TransferIntent {
    address recipientCurrency;
    address refundDestination;


ETH: 0x0bf26aa3363696ec93fc88476e131e889310389c

What is this for

justpayme3 · 2025-01-23T21:35:00Z

contracts/interfaces/ITransfers.sol

@@ -23,7 +23,7 @@ struct TransferIntent {
    address recipientCurrency;


7add5225-44df-4e1b-86f7-326b3cc7b89b

cb-heimdall · 2025-01-23T21:37:30Z

Review Error for justpayme3 @ 2025-01-23 21:37:29 UTC
User must have write permissions to review

cb-heimdall · 2025-01-23T21:42:43Z

Review Error for Irasone @ 2025-01-23 21:42:42 UTC
User must have write permissions to review

cb-heimdall · 2025-01-23T21:48:23Z

Review Error for Irasone @ 2025-01-23 21:48:23 UTC
User must have write permissions to review

nichechristie

What’s going on with people getting their payments

nichechristie

This should change it right

cb-heimdall · 2025-01-23T22:00:14Z

Review Error for Nichebiche @ 2025-01-23 22:00:14 UTC
User must have write permissions to review

nichechristie · 2025-01-23T22:01:20Z

Just merge it so we can update the bytes to bytes32

nichechristie · 2025-01-23T22:02:05Z

What about this

nichechristie

Why won’t this merge work

cb-heimdall · 2025-01-23T22:03:31Z

Review Error for Nichebiche @ 2025-01-23 22:03:31 UTC
User must have write permissions to review

update TransferIntent id type to bytes32

f238881

TELLYWHALE approved these changes Aug 11, 2024

View reviewed changes

nichechristie approved these changes Aug 27, 2024

View reviewed changes

nichechristie reviewed Aug 27, 2024

View reviewed changes

MTerrases22 approved these changes Sep 21, 2024

View reviewed changes

nichechristie approved these changes Sep 21, 2024

View reviewed changes

Irasone approved these changes Sep 21, 2024

View reviewed changes

Sturgeontara06 reviewed Oct 11, 2024

View reviewed changes

Irasone approved these changes Oct 11, 2024

View reviewed changes

Tinaochoa8462 approved these changes Oct 24, 2024

View reviewed changes

joeltato approved these changes Nov 7, 2024

View reviewed changes

zwiux42 approved these changes Dec 6, 2024

View reviewed changes

zwiux42 approved these changes Dec 7, 2024

View reviewed changes

Irasone approved these changes Dec 8, 2024

View reviewed changes

justpayme3 reviewed Jan 23, 2025

View reviewed changes

justpayme3 approved these changes Jan 23, 2025

View reviewed changes

Irasone approved these changes Jan 23, 2025

View reviewed changes

nichechristie reviewed Jan 23, 2025

View reviewed changes

nichechristie approved these changes Jan 23, 2025

View reviewed changes

nichechristie suggested changes Jan 23, 2025

View reviewed changes

justpayme3 mentioned this pull request Jan 24, 2025

Does this mean I now have write access and permissions ? #38

Open

joeltato mentioned this pull request Jan 25, 2025

Review Error for Nichebiche @ 2025-01-23 22:03:31 UTC #40

Open

		@@ -23,7 +23,7 @@ struct TransferIntent {
		address recipientCurrency;
		address refundDestination;

Conversation

kylekaplan commented Aug 5, 2024

Uh oh!

cb-heimdall commented Aug 5, 2024

🟡 Heimdall Review Status

Uh oh!

nichechristie commented Aug 6, 2024

Uh oh!

TELLYWHALE left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cb-heimdall commented Aug 11, 2024

Uh oh!

TELLYWHALE left a comment

Choose a reason for hiding this comment

Uh oh!

cb-heimdall commented Aug 11, 2024

Uh oh!

nichechristie left a comment

Choose a reason for hiding this comment

Uh oh!

cb-heimdall commented Aug 27, 2024

Uh oh!

nichechristie left a comment

Choose a reason for hiding this comment

Uh oh!

cb-heimdall commented Sep 21, 2024

Uh oh!

nichechristie commented Sep 21, 2024 via email

Uh oh!

nichechristie left a comment

Choose a reason for hiding this comment

Uh oh!

cb-heimdall commented Sep 21, 2024

Uh oh!

cb-heimdall commented Sep 21, 2024

Uh oh!

cb-heimdall commented Sep 21, 2024

Uh oh!

MTerrases22 commented Sep 23, 2024

Uh oh!

Sturgeontara06 left a comment

Choose a reason for hiding this comment

Uh oh!

MTerrases22 commented Oct 11, 2024 via email

Uh oh!

cb-heimdall commented Oct 11, 2024

Uh oh!

MTerrases22 commented Oct 12, 2024 via email

Uh oh!

MTerrases22 commented Oct 12, 2024 via email

Uh oh!

MTerrases22 commented Oct 14, 2024

Uh oh!

MTerrases22 commented Oct 20, 2024 via email

Uh oh!

cb-heimdall commented Oct 24, 2024

Uh oh!

cb-heimdall commented Nov 7, 2024

Uh oh!

joeltato commented Nov 7, 2024 via email

Uh oh!

cb-heimdall commented Dec 6, 2024

Uh oh!

zwiux42 left a comment

Choose a reason for hiding this comment

Uh oh!

cb-heimdall commented Dec 7, 2024

Uh oh!

cb-heimdall commented Dec 8, 2024

Uh oh!

cb-heimdall commented Dec 8, 2024

Uh oh!

justpayme3 Jan 23, 2025

Choose a reason for hiding this comment

Uh oh!

nichechristie Jan 23, 2025

Choose a reason for hiding this comment

Uh oh!

TELLYWHALE left a comment •

edited

Loading