Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for: Incorrect imports in Model #388 #389

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix for: Incorrect imports in Model #388 #389

wants to merge 1 commit into from

Conversation

stranma
Copy link

@stranma stranma commented Jul 30, 2024

@CLAassistant
Copy link

CLAassistant commented Jul 30, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@stranma stranma mentioned this pull request Jul 30, 2024
Open
@stranma stranma force-pushed the model-import-fix branch from a473bd2 to 6ef67a6 Compare July 31, 2024 08:17
@a-andre
Copy link

a-andre commented Aug 1, 2024

Removing the imports import mip.* from model.py might also work.

@stranma
Copy link
Author

stranma commented Sep 11, 2024

Removing the imports import mip.* from model.py might also work.

I think this is correct solution, but I don't understand why they are there at first place. So I assume there is some magic which might broke things on unexpected places. Either make larger refactoring and look why import mip.* is here, or at least make it less wrong by this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stranma @CLAassistant @a-andre