Skip to content

DOG-6592: Improve Error logging#502

Merged
Hmnt39 merged 1 commit intomasterfrom
DOG-6592-improve-logging
Jan 21, 2026
Merged

DOG-6592: Improve Error logging#502
Hmnt39 merged 1 commit intomasterfrom
DOG-6592-improve-logging

Conversation

@Hmnt39
Copy link
Contributor

@Hmnt39 Hmnt39 commented Jan 16, 2026

This PR fixes the error logging in the unstable package when config revision changes are detected. The changes ensure errors are properly logged to help with debugging, fix the timing of when the active revision is updated, and refine error messages to be more accurate (changing "crashed" to "failed" for task failures)

@Hmnt39 Hmnt39 requested a review from a team as a code owner January 16, 2026 11:51
@gemini-code-assist
Copy link

Summary of Changes

Hello @Hmnt39, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving the reliability and diagnostic capabilities of the unstable package by refining its error handling and logging mechanisms. The changes ensure that configuration revision updates are processed in a more logical sequence, error messages are more precise, and previously suppressed configuration retrieval errors are now properly logged, ultimately making it easier to debug and understand unexpected behaviors.

Highlights

  • Improved Error Logging: Enhanced error logging within the unstable package, specifically for scenarios where configuration revision changes are detected, to provide clearer debugging information.
  • Timing Correction for Active Revision Updates: Adjusted the timing of when the active configuration revision is updated, ensuring that the _on_revision_change callback receives the correct previous revision before the new one is applied.
  • Refined Error Messages: Updated error messages for task failures, changing the term 'crashed' to 'failed' for more accurate reporting.
  • Version Bump: The package version has been updated from 7.11.3 to 7.11.4.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces several valuable improvements to error logging and handling within the unstable package. The changes include refining error messages for task failures by replacing 'crashed' with 'failed', which is more accurate. A key fix is adjusting the update timing of the active configuration revision to ensure logs correctly reflect the old and new revision numbers upon change. Additionally, error logging has been enhanced to capture failures during remote configuration fetching, which will aid in debugging. The version numbers and changelog have been updated accordingly. Overall, these changes are well-implemented and improve the robustness and observability of the extractor.

@codecov
Copy link

codecov bot commented Jan 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.03%. Comparing base (efa90c7) to head (38246c9).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #502   +/-   ##
=======================================
  Coverage   81.02%   81.03%           
=======================================
  Files          43       43           
  Lines        4211     4212    +1     
=======================================
+ Hits         3412     3413    +1     
  Misses        799      799           
Files with missing lines Coverage Δ
cognite/extractorutils/__init__.py 100.00% <100.00%> (ø)
cognite/extractorutils/unstable/core/base.py 79.54% <ø> (ø)
...ite/extractorutils/unstable/core/checkin_worker.py 88.83% <100.00%> (ø)
cognite/extractorutils/unstable/core/runtime.py 70.58% <100.00%> (+0.12%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Hmnt39 Hmnt39 added the waiting-for-risk-review Waiting for a member of the risk review team to take an action label Jan 20, 2026
@chrfla-cognite chrfla-cognite added the risk-review-ongoing Risk review is in progress label Jan 21, 2026
@chrfla-cognite
Copy link
Contributor

🦄

@chrfla-cognite chrfla-cognite added waiting-for-team Waiting for the submitter or reviewer of the PR to take an action and removed waiting-for-risk-review Waiting for a member of the risk review team to take an action labels Jan 21, 2026
@Hmnt39 Hmnt39 merged commit 18c597b into master Jan 21, 2026
6 checks passed
@Hmnt39 Hmnt39 deleted the DOG-6592-improve-logging branch January 21, 2026 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk-review-ongoing Risk review is in progress waiting-for-team Waiting for the submitter or reviewer of the PR to take an action

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants