-
Notifications
You must be signed in to change notification settings - Fork 2
feat: Add "space-variants" feature #110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -171,7 +171,7 @@ class IdpCdfMapping(Model): | |
|
|
||
| class IdpCdfMappingProjects(Model): | ||
| cdf_project: str | ||
| create_only_mapped_cdf_groups: Optional[bool] = True | ||
| create_only_mapped_cdf_groups: bool = True | ||
| mappings: list[IdpCdfMapping] | ||
|
|
||
|
|
||
|
|
@@ -180,15 +180,16 @@ class SharedNode(Model): | |
|
|
||
|
|
||
| class SharedAccess(Model): | ||
| owner: Optional[list[SharedNode]] = [] | ||
| read: Optional[list[SharedNode]] = [] | ||
| owner: list[SharedNode] = [] | ||
| read: list[SharedNode] = [] | ||
|
|
||
|
|
||
| class NamespaceNode(Model): | ||
| node_name: str | ||
| external_id: Optional[str] = None | ||
| metadata: Optional[dict[str, Any]] = None | ||
| description: Optional[str] = "" | ||
| space_variants: list[str] = [] | ||
| description: str = "" | ||
spex66 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| shared_access: Optional[SharedAccess] = SharedAccess(owner=[], read=[]) | ||
|
|
||
|
|
||
|
|
@@ -199,15 +200,15 @@ class Namespace(Model): | |
|
|
||
|
|
||
| class BootstrapFeatures(Model): | ||
| with_raw_capability: Optional[bool] = True | ||
| with_datamodel_capability: Optional[bool] = True | ||
| with_undocumented_capabilities: Optional[bool] = False | ||
| group_prefix: Optional[str] = "cdf" | ||
| aggregated_level_name: Optional[str] = "allprojects" | ||
| dataset_suffix: Optional[str] = "dataset" | ||
| space_suffix: Optional[str] = "space" | ||
| rawdb_suffix: Optional[str] = "rawdb" | ||
| rawdb_additional_variants: Optional[list[str]] = ["state"] | ||
| with_raw_capability: bool = True | ||
| with_datamodel_capability: bool = True | ||
| with_undocumented_capabilities: bool = False | ||
| group_prefix: str = "cdf" | ||
| aggregated_level_name: str = "allprojects" | ||
| dataset_suffix: str = "dataset" | ||
| space_suffix: str = "space" | ||
| rawdb_suffix: str = "rawdb" | ||
| rawdb_additional_variants: list[str] = ["state"] | ||
|
Comment on lines
+203
to
+211
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is a breaking change. Is it a safe change? Will clients using your library break?
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. it is fully backward compatible, but from 3.5.0 onward supports a new (additional) config semantic versioning from 3.4.1 to 3.5.0 is indicating that, and release-notes will too There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. From what I understand, something that was optional before is now mandatory. I see that as breaking. Did I misunderstand how it works?
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ah you meant removal of A corner case could be that a yaml-config was configured with as this was never documented (and makes no sense) it is theoretical
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. as all have default values it is still optional when parsed by pydantic, just not support |
||
|
|
||
|
|
||
| class BootstrapCoreConfig(Model): | ||
|
|
@@ -276,7 +277,7 @@ class BootstrapDeleteConfig(Model): | |
| Configuration parameters for CDF Project Bootstrap 'delete' command | ||
| """ | ||
|
|
||
| datasets: Optional[list] = [] | ||
| groups: Optional[list] = [] | ||
| raw_dbs: Optional[list] = [] | ||
| spaces: Optional[list] = [] | ||
| datasets: list = [] | ||
| groups: list = [] | ||
| raw_dbs: list = [] | ||
| spaces: list = [] | ||
Uh oh!
There was an error while loading. Please reload this page.