Open
Conversation
Migrates the tests for events to use a proper events mock. There is a workaround here for an old, old possibly bug in the events API, but it's a little fragile, and not really that important to test anymore.
einarmo
force-pushed
the
reusable-events-mock
branch
from
5b6a3a4 to
8439978
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #602 +/- ##
==========================================
- Coverage 77.75% 77.54% -0.22%
==========================================
Files 136 138 +2
Lines 13174 13319 +145
Branches 1974 1993 +19
==========================================
+ Hits 10244 10328 +84
- Misses 2105 2164 +59
- Partials 825 827 +2
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates the tests for events to use a proper events mock.
There is a workaround here for an old, old possibly bug in the events API, but it's a little fragile, and not really that important to test anymore.