feat!: Change Pandas timestamp resolution to ms for timestamp columns#2485
Draft
MortGron wants to merge 1 commit intopysdk-release-v8from
Draft
feat!: Change Pandas timestamp resolution to ms for timestamp columns#2485MortGron wants to merge 1 commit intopysdk-release-v8from
MortGron wants to merge 1 commit intopysdk-release-v8from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently when using
to_pandason list like objects a timestamp resolution of 'ns' is enforced. In Pandas v3 the timestamp resolution is to a much larger extent inferred from the input data, where Pandas v2 would automatically set resolution 'ns'. CDF has a resolution of 'ms', so it would make sense for theto_pandasmethods to also convert timestamp columns toms.An example where keeping resolution 'ns' would be inconenient in Pandas v3 is when using the
from pandas.testing import assert_frame_equalwhere the resolution of timestamp columns are compared.Another reason why chaning the resolution of columns to 'ms' would be convenient, is that a resolution of 'ms' is already set for single objects received from CDF. Only list like objects currently has a resolution of 'ns'.
Checklist:
If a new method has been added it should be referenced in cognite.rst in order to generate docs based on its docstring.