Skip to content

feat(SyntheticTimeSeries): add optional timezone argument to the query method#2465

Merged
haakonvt merged 6 commits intomasterfrom
feat/synthetic-api-timezone
Feb 16, 2026
Merged

feat(SyntheticTimeSeries): add optional timezone argument to the query method#2465
haakonvt merged 6 commits intomasterfrom
feat/synthetic-api-timezone

Conversation

@andreolefirenko
Copy link
Contributor

Description

This PR introduces an optional timezone argument to the SyntheticDatapointsAPI.query method, aligning it with the API specification.
https://api-docs.cognite.com/20230101/tag/Synthetic-Time-Series/operation/querySyntheticTimeseries

Checklist:

  • Tests added/updated.
  • Documentation updated. Documentation is generated from docstrings - these must be updated according to your change.
    If a new method has been added it should be referenced in cognite.rst in order to generate docs based on its docstring.
  • The PR title follows the Conventional Commit spec.

@andreolefirenko andreolefirenko requested review from a team as code owners February 9, 2026 07:33
@gemini-code-assist
Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

@codecov
Copy link

codecov bot commented Feb 9, 2026

Codecov Report

❌ Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.86%. Comparing base (e2f06c0) to head (c0aebe1).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
cognite/client/_api/synthetic_time_series.py 57.14% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2465   +/-   ##
=======================================
  Coverage   48.86%   48.86%           
=======================================
  Files         191      191           
  Lines       26152    26156    +4     
=======================================
+ Hits        12778    12781    +3     
- Misses      13374    13375    +1     
Files with missing lines Coverage Δ
cognite/client/_api/synthetic_time_series.py 73.39% <57.14%> (+0.06%) ⬆️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@haakonvt haakonvt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the existing datapoints methods I see we allow more than just str | None: str | datetime.timezone | ZoneInfo | None. There is existing utility to handle this so I guess you should do the same here. You can look up convert_timezone_to_str

haakonvt
haakonvt previously approved these changes Feb 12, 2026
Copy link
Contributor

@haakonvt haakonvt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for fixing!

@andreolefirenko andreolefirenko added the waiting-for-risk-review Waiting for a member of the risk review team to take an action label Feb 13, 2026
@haakonvt haakonvt self-assigned this Feb 16, 2026
@haakonvt haakonvt added the risk-review-ongoing Risk review is in progress label Feb 16, 2026
Copy link
Contributor

@haakonvt haakonvt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦄

@haakonvt haakonvt added waiting-for-team Waiting for the submitter or reviewer of the PR to take an action and removed waiting-for-risk-review Waiting for a member of the risk review team to take an action labels Feb 16, 2026
@haakonvt haakonvt enabled auto-merge February 16, 2026 07:46
@haakonvt haakonvt added this pull request to the merge queue Feb 16, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 16, 2026
@haakonvt haakonvt added this pull request to the merge queue Feb 16, 2026
Merged via the queue into master with commit 5093814 Feb 16, 2026
18 checks passed
@haakonvt haakonvt deleted the feat/synthetic-api-timezone branch February 16, 2026 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk-review-ongoing Risk review is in progress waiting-for-team Waiting for the submitter or reviewer of the PR to take an action

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants