Skip to content

Repo hardening: fix install instructions, dead imports, hygiene#1

Open
cognis-digital wants to merge 3 commits into
mainfrom
cognis-audit/repo-hardening
Open

Repo hardening: fix install instructions, dead imports, hygiene#1
cognis-digital wants to merge 3 commits into
mainfrom
cognis-audit/repo-hardening

Conversation

@cognis-digital

@cognis-digital cognis-digital commented Jun 12, 2026

Copy link
Copy Markdown
Owner

This PR applies a few small, mechanically-verified hardening fixes found by an automated audit of the Cognis suite:

  • fix 2 broken pip install line(s) in README (package is not on PyPI; use the working git+https install)
  • remove 3 unused import(s) (ruff F401/F811)

Each change is deterministic; all touched Python files were confirmed to still compile (py_compile) before this PR was opened.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your first PR! 🚀 A maintainer will review under the collaboration-pull model (see CONTRIBUTING.md).

@cognis-digital
cognis-digital force-pushed the cognis-audit/repo-hardening branch 2 times, most recently from c2474a6 to 9c92f18 Compare June 13, 2026 12:41
Cognis Digital added 3 commits June 13, 2026 08:41
…rehensive cross-platform install scripts

- README opens with a plain-language "What is this?" overview
- comprehensive Install section + install.sh / install.ps1 (pipx / uv / pip git+https / source)
- verified build-out: real test + CLI audit embedded (README Verification + AUDIT.md)
- core.py: load_boundary now catches PermissionError/OSError/UnicodeDecodeError
  and re-raises as BoundaryError with a clear message; _build_boundary validates
  that each component/flow/poam entry is a dict, rejects whitespace-only required
  fields, and guards coverage_pct against zero-division; strip() applied before
  impact/severity comparisons
- cli.py: catches IsADirectoryError, UnicodeDecodeError, and bare OSError in
  addition to the existing FileNotFoundError/JSONDecodeError/BoundaryError;
  all error paths print to stderr and return exit code 2
- integrations/webhook.py: validates URL scheme before any I/O; skips malformed
  headers with a warning instead of crashing; rejects empty stdin with exit 2;
  distinguishes HTTPError/URLError/TimeoutError in except chain; fixes E401 ruff
  warning (split imports)
- tests/test_hardening.py: 24 new tests covering missing file, malformed JSON,
  invalid boundary fields, whitespace-only required fields, non-dict entries,
  orphan components, bad POA&M dates, CLI exit codes, and empty POA&M output
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant