ati/lpb-173-add-ivs-policy-to-yolo #4
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ati7697
commented
May 19, 2025
|
|
||
| Aws::iam()->attachRolePolicy([ | ||
| 'RoleName' => $role['RoleName'], | ||
| 'PolicyArn' => 'arn:aws:iam::aws:policy/IVSFullAccess', |
Author
There was a problem hiding this comment.
I had to use IVSFullAccess because ReadOnlyAccess doesn't allow us to create channel
Member
|
See #5 |
stevethomas
reviewed
May 19, 2025
Comment on lines
+19
to
+22
| Aws::iam()->attachRolePolicy([ | ||
| 'RoleName' => $role['RoleName'], | ||
| 'PolicyArn' => $policy['Arn'], | ||
| ]); |
Member
There was a problem hiding this comment.
note that this part is redundant because it was already done in AttachRolePoliciesStep.
The name of that step makes me think it would attach multiple policies, which is why I moved it over there instead of adding a new step.
Author
There was a problem hiding this comment.
right, all of them are roles! I thought it should be separate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I made a thing! 🥳
Great! Now please answer the following questions to help out your assigned reviewer:
What problems are you solving?
Is there anything the reviewer needs to know to deploy this?