Skip to content

Conversation

@SethSharp
Copy link
Member

The @close event is not emitted from the DialogContent component, this would cause a warning in the console.

Extraneous non-emits event listeners (close) were passed to component but could not be automatically inherited because component renders fragment or text root nodes

Without the @close handler, the dialog can still be closed via other emitted events escape-key-down and pointer-down-outside.

@SethSharp SethSharp changed the title Remove @close on ConfirmDialog BUG: Remove @close on ConfirmDialog Oct 27, 2025
@SethSharp SethSharp added the bug Something isn't working label Oct 27, 2025
@SethSharp SethSharp self-assigned this Oct 27, 2025
@SethSharp SethSharp merged commit e25b339 into main Oct 27, 2025
1 check passed
@SethSharp SethSharp deleted the seth/remove-unsupported-close-event-on-confirm-dialog branch October 27, 2025 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants