Skip to content

Dev justin #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
name: Lint Workflow

on:
pull_request:
branches:
- develop

jobs:
test:
runs-on: ubuntu-latest

steps:
- name: Checkout Code
uses: actions/checkout@v1

- name: Use Node.js 20.x
uses: actions/setup-node@v1
with:
node-version: 20.x

- name: Install dependencies
run: npm install

- name: Run Lint
run: npm run lint
1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ GitHub Actions is a great solution to this problem. For example, you could creat

## Initial Project Setup

TODO: this definitely doesn't work
To begin, start by forking the following repository [GitHub Actions Demo](https://github.com/coding-boot-camp/github-actions-demo). Once you have forked this repository you should then clone the forked repository to your local machine.

## Create the Workflow
Expand Down
6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
"dev": "vite --port 3000",
"build": "tsc && vite build",
"lint": "eslint src --ext js,tsx --report-unused-disable-directives --max-warnings 0",
"preview": "vite preview",
"eslint": "eslint src",
"preview": "vite preview",
"eslint": "eslint src",
"test": "vitest"
},
"dependencies": {
Expand All @@ -33,4 +33,4 @@
"vite": "^4.4.5",
"vitest": "^2.0.4"
}
}
}
2 changes: 1 addition & 1 deletion src/components/Advertisement.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ interface AdvertisementProps {
companyName: string;
productDescription: string;
price: string;
};
}

function Advertisement(props: AdvertisementProps) {
return (
Expand Down