Code

generalize profile links#1524

Code

Merged

ArtOfCode- merged 58 commits intodevelopcodidact/qpixel:developfrom cellio/1248-generalize-profile-linkscodidact/qpixel:cellio/1248-generalize-profile-linksCopy head branch name to clipboardFeb 13, 2025

Commits

Commits on Jan 24, 2025

• checkpoint: created new table, user profile page shows values if present, edit form is a layout mess and doesn't accept edits yet, attempt at URL validation not yet hooked up

  cellio

  committed
  26494ff

  Copy full SHA for 26494ff

• less-bad layout

  cellio

  committed
  d95d0e0

  Copy full SHA for d95d0e0

Commits on Jan 26, 2025

• spacing tweak

  cellio

  committed
  b2b2593

  Copy full SHA for b2b2593

• attempting to validate URLs (doesn't work)

  cellio

  committed
  6ef2850

  Copy full SHA for 6ef2850

• remove redundant form (edits can now be submitted but they don't update)

  cellio

  committed
  0c3f710

  Copy full SHA for 0c3f710

• put error-handling in correct place

  cellio

  committed
  afe68b2

  Copy full SHA for afe68b2

• make sure we assign response?

  cellio

  committed
  6ddbe00

  Copy full SHA for 6ddbe00

• comment

  cellio

  committed
  fb0fd7f

  Copy full SHA for fb0fd7f

• minor cleanup (these were probably bugs but not the only ones)

  cellio

  committed
  119fac3

  Copy full SHA for 119fac3

• review feedback

  cellio

  committed
  17a3bde

  Copy full SHA for 17a3bde

• added some comments

  cellio

  committed
  65e3b71

  Copy full SHA for 65e3b71

• Merge branch 'develop' into cellio/1248-generalize-profile-links

  Oaphi

  authored
  00c0a01

  Copy full SHA for 00c0a01

• fixed up rubocop errors

  Oaphi

  committed
  c7f5dd5

  Copy full SHA for c7f5dd5

Commits on Jan 28, 2025

• installed maintenance task gem (see https://github.com/Shopify/maintenance_tasks) and added task to set up user_websites table for existing users

  cellio

  committed
  c37592e

  Copy full SHA for c37592e

• filter out not-real user_websites

  cellio

  committed
  32a742a

  Copy full SHA for 32a742a

• rubocop

  cellio

  committed
  2a9d3e0

  Copy full SHA for 2a9d3e0

Commits on Jan 29, 2025

• need to access the user_websites attrs explicitly

  cellio

  committed
  37f8548

  Copy full SHA for 37f8548

• need both in the permit list

  cellio

  committed
  11a5c89

  Copy full SHA for 11a5c89

• fixed :user_websites_attributes accessors

  Oaphi

  committed
  12ccc61

  Copy full SHA for 12ccc61

• validated_profile_websites should correctly transform values

  Oaphi

  committed
  8c71e6f

  Copy full SHA for 8c71e6f

• removed no longer needed validate_profile_website

  Oaphi

  committed
  de877bf

  Copy full SHA for de877bf

• temporarily fixed :twitter not being adding to permitted params

  Oaphi

  committed
  a89c730

  Copy full SHA for a89c730

• removed unnecessary comments

  Oaphi

  committed
  d8d7104

  Copy full SHA for d8d7104

• 'invalid external link' should only be flashed if there actually are errors

  Oaphi

  committed
  c37f016

  Copy full SHA for c37f016

• added User#same? method

  Oaphi

  committed
  acaa348

  Copy full SHA for acaa348

• validated_profile_websites should only return those params that have non-nil urls

  Oaphi

  committed
  a38f0e1

  Copy full SHA for a38f0e1

• fixed danger notice when some of the user website links are invalid

  Oaphi

  committed
  27979fb

  Copy full SHA for 27979fb

• temporary fix for users_controller tests until twitter/discord is removed

  Oaphi

  committed
  e80b93d

  Copy full SHA for e80b93d

• switched to maintenance_tasks v2.1.1 (can't test Ruby 2.7.8 on higher versions)

  Oaphi

  committed
  d35dbd4

  Copy full SHA for d35dbd4

• default order so edit page will work right

  cellio

  committed
  1a3d4fa

  Copy full SHA for 1a3d4fa

• simplication: allow anything, only linkify http links, and apply nerf rules to whole section

  cellio

  committed
  2223e5d

  Copy full SHA for 2223e5d

Commits on Jan 30, 2025

• catch blank values and convert to nil for DB constraint, and now we no longer need to seed labels

  cellio

  committed
  92cd458

  Copy full SHA for 92cd458

• removed validated_profile_websites as we don't use it anymore

  Oaphi

  committed
  981b92e

  Copy full SHA for 981b92e

• rubocop fix for user model

  Oaphi

  committed
  74926e1

  Copy full SHA for 74926e1

• remove unused fields from edit form

  cellio

  committed
  0169871

  Copy full SHA for 0169871

• removed unused method

  cellio

  committed
  5c8b48d

  Copy full SHA for 5c8b48d

• rubocop (someday I will figure out why my editor is adding those utf-8 lines and kill it...)

  cellio

  committed
  32428a8

  Copy full SHA for 32428a8

• removed website and twitter sections, moved discord below extra fields

  cellio

  committed
  4a36962

  Copy full SHA for 4a36962

• removed no longer needed ensure_protocol

  Oaphi

  committed
  73dc8b1

  Copy full SHA for 73dc8b1

• add CSS classes for mobile

  cellio

  committed
  e10334d

  Copy full SHA for e10334d

Commits on Jan 31, 2025

• on login, ensure that the right number of rows in user_websites exists

  cellio

  committed
  134e0e0

  Copy full SHA for 134e0e0

• really, rubocop? screaming constants? SHOUTING IS RUDE :-P

  cellio

  committed
  d6b4e6c

  Copy full SHA for d6b4e6c

• oh, *that's* how you attach it to user creation! (moved ensure call)

  cellio

  committed
  ac5ad73

  Copy full SHA for ac5ad73

Commits on Feb 1, 2025

• renamed User#same? method to User#same_as?

  Oaphi

  committed
  20e3810

  Copy full SHA for 20e3810

• fixed up newly introduced tab stops

  Oaphi

  committed
  3a663c0

  Copy full SHA for 3a663c0

• 'present? or nil' is exactly what 'presence' does

  Oaphi

  committed
  afacd50

  Copy full SHA for afacd50

• test for fixing the pipeline

  Oaphi

  committed
  ca1d60a

  Copy full SHA for ca1d60a

• Revert "test for fixing the pipeline"

  Show description for c28a253
  Oaphi

  committed
  c28a253

  Copy full SHA for c28a253

• removed unnecessary comments from user websites maintenance tasks & empty 'count'

  Oaphi

  committed
  23c1a02

  Copy full SHA for 23c1a02

• user_id is implicit when accessing user.user_websites

  Oaphi

  committed
  704feaa

  Copy full SHA for 704feaa

Commits on Feb 2, 2025

• update user controller test to remove website/twitter, add discord

  cellio

  committed
  a152b4a

  Copy full SHA for a152b4a

• where().size.positive? can be shortened to exists?(<conditions>)

  Oaphi

  committed
  d766380

  Copy full SHA for d766380

• UsersController#update_profile should allow partial updates

  Oaphi

  committed
  2d52f7e

  Copy full SHA for 2d52f7e

• split the overloaded update_profile test

  Oaphi

  committed
  720ee8b

  Copy full SHA for 720ee8b

Commits on Feb 4, 2025

• add editor test for user_websites

  cellio

  committed
  4b72f57

  Copy full SHA for 4b72f57

• rubocop

  cellio

  committed
  80db9e9

  Copy full SHA for 80db9e9

Commits on Feb 7, 2025

• Merge branch 'develop' into cellio/1248-generalize-profile-links

  cellio

  committed
  e0b2467

  Copy full SHA for e0b2467

Commits on Feb 12, 2025

• removed route, which is not access-protected, in favor of running tasks from the command line

  cellio

  committed
  aad579e

  Copy full SHA for aad579e