Certifications outrank course and filtering for certifications - #151
Merged
davidtaing merged 2 commits intoSep 12, 2026
Merged
Conversation
# Conflicts: # src/app/p/_lib/profile-detail.tsx
nicholas-crawford
marked this pull request as ready for review
September 11, 2026 05:51
davidtaing
approved these changes
Sep 12, 2026
davidtaing
left a comment
davidtaing
left a comment
Collaborator
There was a problem hiding this comment.
Looks really nice. Thanks @nicholas-crawford. LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The ranking of credentials has been reordered on the directory page so that certifications out rank courses. There has also been a label and icon added to show when a credential is a certification and also it's source. (See below image) Filtering has been added for each certification. There has been modification to the filter spacing to account for the new label.
Related issue
Closes #130
Checklist
pnpm lintpassed, where applicablepnpm test:e2epassed, where applicableCo-Authored-By,Generated with, or tool-attribution trailers